I use DevonThink (Mac-only). In addition to continuous archiving of email, it indexes and stores attachments, files all my receipts, and keeps my PDFs and archived notes there. Very powerful and reliable search.

https://www.devontechnologies.com/apps/devonthink