Hacker Newsnew | past | comments | ask | show | jobs | submitlogin
[flagged] GitHub taking down tools allowing defenders to reproduce the Log4j vulnerability (twitter.com/christophetd)
212 points by christophetd on Dec 13, 2021 | hide | past | favorite | 94 comments


A GitHub employee replied on Twitter:

https://twitter.com/_mph4/status/1470343429599211528

> I just personally looked into this and can confirm we did not take down this repo nor are we actively removing Log4j related content from @github , consistent with our policies re: dual-use

Maybe too early to grab pitchforks?


I made wrong assumptions when writing this tweet. I clarified this on Twitter. Apologies for the confusion. Not sure if it makes sense to delete the tweet / thread.


The tweet has been removed. Now that this has been clarified, I don't want to be a vector for spreading inaccurate information.


good, but too late, damage for the company was already done


If a tweet is wrong and you're not out to spread FUD, you delete the tweet. That's standard procedure.


Is it? Usually I see people post replies apologizing and including the truth


Yes


UPDATE: GitHub CISO pointed out that GitHub did NOT take down the JNDI Exploit repository.

https://twitter.com/_mph4/status/1470343429599211528

https://twitter.com/christophetd/status/1470346676053422081

This is surprising, considering what is outlined in a previous comment[1]. I hope GitHub provides more transparency on the takedown actions for "malicious content / exploits" like they do for DCMA notices[2].

Apologies for making wrong assumptions. I removed the original Tweet (see screenshot[3] for the original).

[1] https://news.ycombinator.com/item?id=29538151

[2] https://github.com/github/dmca

[3] https://i.imgur.com/sJe3OTI.png


They do this every time, and have a previously stated spproach of blocking zero day attack scripts for the first X days of a zero day, when they deem it sufficiently dangerous to the Internet. So, yes, yet again, they’re doing this, just as they always do. Is there something new this time that makes this newsworthy?


Every time this happens we should think about how powerful github has become and why are we collectively allowing this.


Git allows multiple remotes, and it really isn’t that hard to self host something like gitlab.

For people that operate near the edges of acceptable (create tools that are VERY easy to misuse) this kind of redundancy should be SOP


Put the zip file to your static site, mirror to bitbucket, mirror to sourcehut. I have more doubts, that you don't find the code. Maybe a link inside the CVE would be good.


Absolutely, but that doesn't make this kind of decisions at any particular host less bad.


As far as I can tell the existing policy is not to allow public repos of a zero day vuln exploit while it is still unpatched. The code is allowed after the issue is mitigated

This seems like a pretty reasonable policy all things considered


Github isn't powerful per se, they just capture a high percentage of the market for online code hosting. But it's just one website. Anyone can set up a git repo, an instance of a git host, etc.


Everyone can, but most just use Github. As a consequence they get to shape the development processes of pretty much anyone and also to do shit like this.


"Shape" is too broad. Everyone has access to lots of almost identical tools from competitors. It's like saying Ford get to "shape" the driving experience of millions - so what? And switching Git provider is much easier than switching car.


> "Shape" is too broad. Everyone has access to lots of almost identical tools from competitors.

Exactly. That's precisely because Github is so big that nobody (except possibly sourcehut, but that's niche) dares to do anything differently and everyone just blindly copies whatever Github does. If that's not "shaping the development experience for everyone", I don't know what is.


> everyone just blindly copies whatever Github does

I don't think this is true.


I’d love to read a longform blog post about that. Anything that fits into a tweet has already been said a bunch of times already, and hasn’t made a compelling case that there’s a problem here.

I’m pretty sure they only takedown exploit code, not scanner code, but people often choose not to distinguish those conceptually, which makes it quite difficult to have a discussion about it.

Also, see top reply on this post, which references a dual-use policy: https://twitter.com/_mph4/status/1470343429599211528


Would help if gitlab didn't block search engines from indexing it.


github isnt powerful


They seemed pretty powerful while I was waiting for codex access.

I could imagine a world where a select segment of developers got access to an even more impactful tool, with the rest being left out due to arbitrary opaque decisions. How did they even pick who to allow early Codex access? Was it some intern just looking at Google Forms submissions? An algorithm?

GitHub is depended on by most of the software engineers of the world, who themselves hold immense power to decide society's path. All that to say, GitHub is powerful.


I think it meant "powerful" in terms of reliance. When the storage has the items, good, when it locks you out, you are left itemless.

(A limited redundancy warning, along the lines of having mirrors, archives, distributed information etc.)


Care to elaborate why you believe so?


I'm much more worried about everyone on this site just believing everything they read, then instantly getting mad instead of doing a simple "is this really true" search or even gaining a single data point of their own.

this whole culture is just freaking ripe for manipulation. it's so easy.



Finding information that is "censored" or restricted by going to a Chinese source ... gobsmacking levels of irony. :D


I get what you mean, but also worth noting that the vulnerability was discovered by Chen Zhaojun of Alibaba Cloud Security Team.


YES, Agree.

To be honest, after I posted the comment I was unsure if I ought to edit to add that I don't mean it as a diss or with any ill intent... to any human. Just an amusing "isn't this cute" parallel.

And also I sorta want to add something about necessity being the mother of invention. There's a lot of very high quality proxy/vpn/DPI evasion code that seems to come from China. ;)


[flagged]


Its not safe to assume such clearly bigoted things. In fact the worlds safety levels are impinged negatively by such hubristic nationalism. Its probably safer to assume this was discovered by the NSA years ago and left unreported for their own hijinks - after all, the NSA has a far worse track record of violating peoples human rights than, pretty much, any other organization on the planet.


[flagged]


Nothing 'whatabout' it: the moral authority you think you have, does not exist.

Thus, your prejudice is clear and you'd be better off directing your ire towards an institution you can actually do something about as a member of a Western democracy or one of the 5-eyes superstate member nations: the NSA.


Why not both? Places like HN are full of legitimate criticism of western abuses of power, and you can plainly see it if you do a search, since it doesn’t get scrubbed from the internet unlike certain places.


>Why not both?

  * Americans criticizing China = war
  * Americans criticizing America = civil society
Shouldn't even have to explain it. Americans can do NOTHING about China for as long as they do nothing about the USA.


Literally every country in the world hoards every zero day they can get their hand on.


Yes, I expect the NSA to get first dibs on using anything Amazon discovers too. Two wrongs do not make a right.

And I’m not sure how good of a strategy it really is, at least not for the west. The value in using zero days for attacking enemies is highly speculative and not subject to public scrutiny, but the value in rolling out fixes as soon as possible to protect against anyone else is easily felt by everyone. I believe independent security researchers still exist, and they are worth fighting for.


I can smell the xenophobia from miles away.


Criticising a political system is not xenophobia.


"Chinese" is not a political system.


“Chinese” was used twice in the post; once in the informal (and usually hostile) abbreviation “CCP” for “Chinese Communist Party” and in “with Chinese characteristics”, a reference toa political motto of the same party identified by the abbreviation, the Communist Party of China (CPC), who describes their system as “socialism with Chinese characteristics”.

So, yes, it's a reference to a particular political platform, not a nationality. It's no more ethnically bigoted than blaming a problem on the US Democratic or Republican party is.


The CCP is a political party, it being the only legal party is a political system. And I’m criticising it.

If you’re offended by the “with Chinese characteristics”, look up the origin of the phrase. It’s CCP code for “it’s not wrong when we do it”. When people questioned Deng Xiaoping’s reforms as being capitalist he responded with “it’s socialism with Chinese characteristics, I ain’t gotta explain shit”.


most the large enterprise has a direct connection to THE internet


This is disappointing. I used this tool to understand the vulnerability within the first few hours of response. It allowed me to prove mitigations worked, and therefore gave certainty.


But there's not only Github. They can just use Gitlab or if that does not work Codeberg. Somehow the whole industry really seems to be content with bootlicking any of the Big Five.


The problem with betting on the underdog is that the internet is still young. GitHub has momentum; it may not have a guaranteed long-term future, but as of now it is the open source project forge with the best long-term outlook. If you had bet on Google Code, your project is at least still accessible today. If you bet on Sourceforge, the same is true, although for a period of time you could’ve had your own project page distributing malware. (I am aware that it has changed hands since these incidents, but this still happened nonetheless.) GitLab also seems like an OK bet… but from there on out, it feels like you have to be careful. A random Gitea instance is never a safe bet. Even if you run it on your own, you don’t know how long you’ll be around to keep the lights on; life is fragile.

I still find Golang’s module cache mechanism to be bothersome in some regards, but I think they were on the money with their concerns. It’s probably the only way modules can stay “decentralized” with confidence. But, that solution requires at least one central entity that is trusted and can shoulder the costs of such a service; and it only solves a narrow portion of the problem, relevant to the module system of a single programming language.

There’s no easy way out; nothing is truly autonomous. Explicitly organized groups of people running a legitimate business probably have a better long-term outlook than a band of cypherpunks running P2P services, or what have you. (Believe me, it pains me to say it, because I sure wish it wasn’t so.)

In this way, I think it’s obvious why people pick GitHub. It’s because it’s in the best position of the best segment for code hosting. It’s backed by a billion dollar multinational corporation. It’s been around the block a few times and is a robust business of its own.

Even if your concern isn’t longevity, GH is still giving you the best standing as far as network effects go. It’s just hard to blame anyone.


Blockchain to the rescue! /s


GitHub is running on momentum at this point. I only use it for cloning nowadays. They've even made that a hassle, I'd like to use SSH for all my connections, but it seems like they'd prefer I got their shitty custom tool, or used https and typed a lot of passwords.

These days for preference I'll use shart (sr.ht) or, even better, the project's own git server.


ssh works fine for me.. what issue are you having?


I think it defaults to showing the https cloning link when you're not logged in (and possibly don't have your public key added to your github account). While logged in it also defaults to ssh for me and works just fine.


You can easily work around that by putting this in your .gitconfig:

    [url "git@github.com:"]             
            insteadOf = git://github.com/
            insteadOf = http://github.com/
            insteadOf = https://github.com/


This is literally magic and has been yoinked into my dotfiles.


Or just, ya know, a $5 linode holds my git repos just fine. :) The problem is the centralization/SPOF itself, not whatever platform or SPOF used.


Github is owned by Microsoft. Github IS the big five.


That's OPs point though.


Is it? So Github is bootlicking itself?


Developers are bootlicking Github when they keep deciding to host stuff there.


Is there any indications that it was taken down by GitHub and not by the owner themself?


It's a good point. I added a disclaimer to the tweet while confirming this, but I'm confident it's a GitHub takedown following their new policy: https://github.blog/2021-04-29-call-for-feedback-policies-ex...


If anyone working at GitHub reads this, I opened support ticket #1425405 to request a confirmation.



Is there any indication that the owner took it down himself while claiming GitHub did it?


Where have the owner claimed that it was taken down?


As far as I know, the owner of JNDIExploit did not claim that GitHub took the repo down. I am trying to find their contact information to remove any doubts around this.


What if GitHub, is the owner?



So what? There is plenty of ressources on how to fix the vulnerability. Those who really want to see the code will find it anyways, both maliscious actors and admins.

This mostly prevents skids from getting hold of it and using it against their school etc


I'm honestly kinda surprised. The policy seems willfully ignorant of the Streisand effect. I get the reasons behind it, I'm just surprised it wasn't laughed down at some internal Github planning meeting. "No, that'll never work Dave! 09 F9 11 02 9D 74 E3 5B D8 41 56 C5 63 56 88 C0, remember?"


For anyone else who is wondering what's up with that hex string:

AACS encryption key controversy

https://en.m.wikipedia.org/wiki/AACS_encryption_key_controve...


Does the key still work?


Interesting question. I have no idea if it's still relevant, though I imagine it is, and with the magical bytes being siloed in some file far, far away from VLC and libaacs.

It always strikes me as amusing that here we are, in the 21st century, and people are still trying to use shibboleths as a reasonable and scalable means of security. At least "ourhardworkbythesewordsguardedpleasedontsteal(c)AppleComputerInc" has some internal humor to appreciate.

Tangentially, FCKGW-... ;)


You all know that in Germany for example it is strictly forbidden to publish/code such tools.

From what I know there are also other countries that do the same.

So now GitHub would have to implement region availability not to get into trouble with German law.

Let alone this is so fresh that preventing script kiddies from downloading a tool is perfectly valid move.


Yeah nah. While the particular law is incredibly vague nonsense, if the purpose of the tool is security research or to harden your infrastructure against the impact of the vulnerability (as opposed to preparation of an actual crime) it would not be illegal to publish this in Germany.


Could you go into this a bit, is there caselaw you're relying on? AIUI (and I've not being following closely) Germany's equivalent to CFAA (in USA, or CMA in UK) makes the provision of 'hacker' tools capable of being used for intrusion to be a crime. Honestly, I thought it was an absolute liability law (that you can't work around by proving you had no ill intent)?


IANAL but the few cases I'm aware off have all been thrown out. The hacker tool provision in question starts out from a position of intent [0] (which was part of why a high profile case where a journalist sued themselves was thrown out). I'm honestly not aware of a case where this was successfully applied in court since it's inception in 2007. I might have missed some smaller stuff over the years but as long as you're not actively advertising your make-pretend "dual use" malware exclusively on the dark net you'd likely be fine. Germany's supreme court has relatively early on argued on a pretty strict interpretation of the paragraph (according to various publications related to [1] back around 2010).

There have apparently been a few search warrants that referenced it but otherwise it's pretty much the toothless tiger you'd expect from a country that relies on potentially "dual use" software the paragraph would likely apply to in wider interpretations (or at least seems to be in constant talks with spyware manufacturers for their own executive branches).

[0] https://dejure.org/gesetze/StGB/202c.htm

[1] https://dejure.org/dienste/vernetzung/rechtsprechung?Text=2%...

edit: Okay, apparently I've missed a few [3] where it was actually applied. Maybe don't spy on people using keyloggers, but I'm sure other laws cover that part as well.

[3] https://dejure.org/dienste/lex/StGB/202c/1.html


Thanks, I'm not really a German language reader do that gives me something to go on with.


They already have the mechanism in place and actively use it to block content by region as requested by respective governments.

https://docs.github.com/en/github/site-policy/github-governm...

https://github.com/github/gov-takedowns


Looks like original is up? Or is it a re-upload?

https://github.com/Jeromeyoung/JNDIExploit-1


The author of this tweet asks for upvotes on Twitter[1]. isn't that against rules?

[1] https://twitter.com/christophetd/status/1470293533416427524?...


If that's against the rules, let me know and I will remove the post. It was never my intention to go against HN rules.

(I suggested that people upvote the thread for visibility in the community and to start the discussion. When something reaches HN frontpage, I believe it's the voice of the community, not mine anymore)


I have now removed the tweet linking to this HN thread to ensure I am abiding by HN rules.


Thanks. Fwiw I agree with your tweet and personally upvoted it


The tweet is also wrong, github has responded and claimed they didn't remove the repo.


Pretty sure upvoting for agreement is okay? Also, policing what people say outside HN doesn’t seem productive or supported by the rules.


> Don't solicit upvotes, comments, or submissions. Users should vote and comment when they run across something they personally find interesting—not for promotion.

https://news.ycombinator.com/newsguidelines.html

(just quoting what seems relevant, don't know if this actually falls under that item in the guidelines)


Thanks for pointing this out.

To make sure I respect the rules, I removed my tweet linking to the HN thread suggesting people to upvote it for the matter to have more visibility.


Github taking down whitehat tool for reproducing vulnerability.

The title as it stands begs the question: Who is "allowing defenders", Github or the tools? Also "defenders" is a weird word to use here.


Sure, a tool for defenders... like Kali Linux is for security researchers..


Whoever wants this gone is actively scrubbing it from GitHub (ie, it seems to be GitHub doing this). A few moments ago I found https://github.com/0x727/JNDIExploit, but while browsing around the repo suddenly went 404. Wow.

However, it seems that the way GitHub handles forks vs user deletions is that when a user deletes a fork (or it's Done For Them™), it seems that the fork "root owner" is transferred within the chain to someone else. I don't quite get it. Or maybe something else is going on.

In any case, a few minutes ago https://github.com/search?l=&q=filename%3AJNDIExploit.iml&ty... was showing JNDIExploit under "0x727", but now the page is showing the repo "owned" by a different user (with the network graph on the repo page showing everyone else as forking the repo from that new user).

So the above search link is your best bet to finding the repo. It's currently listed as owned by "zzwlpx", but you'll probably see a different user (especially if https://github.com/zzwlpx/JNDIExploit no longer works).

It currently has 245 forks, so good luck, GitHub, keeping this squashed. [Edit: I now see a comment mentioning that GitHub has a policy of trying to squash 0days for the first X days, which is a very understandable reaction given that it's where everyone goes, from the skiddies who just like seeing things burn (and prevent everyone from having nice things, to the researchers trying to respectfully evaluate damage. Sigh.]

---

Some other things I found while playing with GitHub search:

https://github.com/zhuowei/GhidraLog4Shell

https://github.com/samjcs/log4shell-possible-malware

https://github.com/mbechler/marshalsec/


That's useful, thanks for sharing! Based on this, it seems extremely likely that GitHub has taken down JNDIExploit, as opposed to its owner removing it themselves. (See the question raised in https://news.ycombinator.com/item?id=29537822)


Remember GitHub is not Git. Needs to be pushed elsewhere. Everywhere.


Don't upload it to fucking Github.

And fuck github.


Thanks for these elaborate arguments against GitHub. This really gave me some insights and ideas I didn't have previous reading your reasoning. I'll consider using an alternative now. Thanks again for your effort.

/s


Sorry to be un-HN-like, but thanks for the laugh :D


You're welcome.

/s




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: